This project is read-only.

Is the BeginRequest event handler in the PermissiveXFrameHeaderModule necessary?

Jun 10, 2015 at 8:43 AM
Hi,

I'm thinking that since the EndRequest handler always remove the X-FRAME-OPTIONS, why is the BeginRequest needed? I'm looking at the 2013 version. Are there any scenarioes where EndRequest is not run?

If I'm right I suggest removing the BeginRequest to reduce complexity and a potential performance impact?

Best regards
Petter Skodvin-Hvammen
Jun 12, 2015 at 5:17 AM
It's not needed. It was the initial implementation to do it "the proper way" but it didn't catch all scenario's so I reverted to the more brute EndRequest. You can remove it. The implementation is so light it won't have any noticeable performance impact, but superfluous code is better avoided indeed.

Kind regards